Skip to content

[stack] feat(mail): highlight warnings in account security emails - #65222

Merged
skjnldsv merged 2 commits into
masterfrom
feature/security-mail-notes
Oct 8, 2026
Merged

[stack] feat(mail): highlight warnings in account security emails#65222
skjnldsv merged 2 commits into
masterfrom
feature/security-mail-notes

Conversation

@skjnldsv

@skjnldsv skjnldsv commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Builds on #65221. The sentence that matters in security mails now stands out in a warning or info box instead of being buried in the text.

Mail Change
Remote wipe started / finished Warning / info box
Password changed "If you did not request this…" in a warning box
Email changed Same warning box, plus a card with the old and new address
Code integrity changed The findings in a warning box

New strings: "Previous email address", "New email address".

Before After (light) After (dark) Mobile
Remote wipe started
Remote wipe finished
Password changed
Email changed
Code integrity

Browser renders of the real code with sample data, after includes the restyle from #65194. Not checked in mail clients.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests are included
  • Screenshots before/after for front-end changes
  • Documentation has been updated or is not required
  • Backports requested where applicable
  • Labels added where applicable
  • Milestone added for target branch/version

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

@skjnldsv skjnldsv added this to the Nextcloud 36 milestone Oct 6, 2026
@skjnldsv skjnldsv self-assigned this Oct 6, 2026
@skjnldsv
skjnldsv force-pushed the feature/security-mail-notes branch from ab97722 to 418e03f Compare October 6, 2026 18:15
@skjnldsv
skjnldsv force-pushed the feature/security-mail-notes branch 2 times, most recently from 418e03f to ddd7889 Compare October 6, 2026 18:23
@skjnldsv skjnldsv changed the title feat(mail): highlight warnings in account security emails [stack] feat(mail): highlight warnings in account security emails Oct 6, 2026
@skjnldsv
skjnldsv changed the base branch from feature/mail-template-blocks to feature/dav-mail-blocks October 6, 2026 18:24
@skjnldsv skjnldsv mentioned this pull request Oct 6, 2026
Merged
5 of 9 tasks
@skjnldsv
skjnldsv added this pull request to stack #65223 October 6, 2026 18:34
@skjnldsv
skjnldsv marked this pull request as ready for review October 6, 2026 18:35
@skjnldsv
skjnldsv requested a review from a team as a code owner October 6, 2026 18:35
@skjnldsv skjnldsv removed the 2. developing Work in progress label Oct 6, 2026
@skjnldsv
skjnldsv requested review from CarlSchwan, come-nc, leftybournes and provokateurin and removed request for a team October 6, 2026 18:35
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Oct 6, 2026
@skjnldsv
skjnldsv force-pushed the feature/security-mail-notes branch from ddd7889 to 903079e Compare October 6, 2026 20:27
@skjnldsv skjnldsv mentioned this pull request Oct 6, 2026
Merged
5 of 7 tasks
@skjnldsv
skjnldsv force-pushed the feature/security-mail-notes branch from 903079e to 4e6b2a0 Compare October 7, 2026 08:25
@skjnldsv
skjnldsv requested a review from tcitworld as a code owner October 7, 2026 09:34
@skjnldsv
skjnldsv force-pushed the feature/security-mail-notes branch from 4e6b2a0 to 1bf7624 Compare October 7, 2026 09:34
jancborchardt
jancborchardt previously requested changes Oct 7, 2026
View reviewed changes

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, only 2 details:

  • The coloring should be the same as used for NcNoteCard so contrast is proper
  • The left border bar follows the radius strangely on the top and bottom. Instead it would be good to use the same mechanism as we do for the NcNoteCard component so it’s a sharp line on the left (with rounding still).

(Using an icon like in the component is not necessary, would be too noisy.)

@skjnldsv
skjnldsv force-pushed the feature/security-mail-notes branch from 1bf7624 to c961686 Compare October 7, 2026 16:43
@skjnldsv
skjnldsv force-pushed the feature/security-mail-notes branch from c961686 to de0ae23 Compare October 7, 2026 17:57
@skjnldsv
feat(mail): highlight warnings in account security emails
44aa123 
Put the key sentence of the remote wipe, password changed, email changed
and code integrity emails into a warning or info note. The email changed
mail also shows the previous and new address in a details card.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@skjnldsv
skjnldsv force-pushed the feature/security-mail-notes branch from de0ae23 to 44aa123 Compare October 7, 2026 17:58
@skjnldsv

skjnldsv commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

On it!

(Using an icon like in the component is not necessary, would be too noisy.)

Yyes, I agree too 💪

@skjnldsv
fix(mail): match note colors and bar to NcNoteCard
ae79ea5 
Use the theme's info, warning and error colors for the note box
background and its text color for the left bar, in light and dark
mode, and the small border radius so the bar stays straight.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@skjnldsv

skjnldsv commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Done in ae79ea5 🎨 Notes now use the same theme colors as NcNoteCard (background from --color-*, bar from --color-*-text, also in dark mode) and the small radius, so the bar is a straight line. No icon. Screenshots are updated.

E.g.
mail-security-after-remote-wipe-finished-dark-700
mail-security-after-email-changed-light-700

Base automatically changed from feature/dav-mail-blocks to master October 7, 2026 18:49
@skjnldsv
skjnldsv merged commit 2d71d07 into master Oct 8, 2026
163 of 165 checks passed
@skjnldsv
skjnldsv deleted the feature/security-mail-notes branch October 8, 2026 00:56
@skjnldsv skjnldsv mentioned this pull request Oct 8, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselb kesselb kesselb approved these changes
@hamza221 hamza221 hamza221 approved these changes
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend
@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend
@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend
@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend
@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst
@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski
@tcitworld tcitworld Awaiting requested review from tcitworld
@jancborchardt jancborchardt Awaiting requested review from jancborchardt
@pabzm pabzm Awaiting requested review from pabzm

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews AI assisted enhancement feature: emails

Projects

None yet

Milestone

Nextcloud 36

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @jancborchardt @kesselb @hamza221